Skip to content

Edit old wallet runs as profit and minutes; remove wallet chaining #49

Closed

Description

@Fazorath

Parent

#38

What to build

Old wallet-based runs are corrected as a plain profit and duration, and the wallet chaining between runs goes away. This is the contract step, after the GUI and CLI have moved to cargo runs.

  • Editing an old wallet run (wallet-after set, no cargo values) takes Profit (M) and Minutes directly and changes no other run. The Abyss edit dialog shows those two fields for such a run.
  • Deleting any abyssal run no longer re-bases the next run.
  • Removed: the wallet re-chaining on edit, the helper that finds the next run in the chain, "current wallet from the run log", and the wallet-based abyss logging method. Nothing should still call them once the earlier tickets have landed; if something does, stop and report it.
  • Old wallet runs keep the profit they were logged with. Totals and history don't change.

Acceptance criteria

  • Editing a wallet run's profit and minutes updates only that run; the run after it keeps its profit
  • The edit dialog shows Profit (M) and Minutes for a wallet run, and the cargo fields for a cargo run
  • Deleting a wallet run or a cargo run leaves every other run unchanged
  • The wallet-chaining code paths are gone and nothing references them
  • Lifetime totals for a database of old wallet runs are the same before and after this change
  • Tests:
    • Tracker: editing a wallet run, delete without re-basing (wallet and cargo runs)
    • GUI through gui.App: the wallet-run edit dialog
    • The old wallet-chaining and delete/edit re-base tests are rewritten for the new behaviour or removed
  • Full test suite green

Blocked by

Metadata

Metadata

Assignees

Labels

esiEVE Online ESI integrationready-for-agentSpec'd and safe for the night shift to build

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions