Repository navigation
Fetch from EVE for cargo before / cargo after - #54
Merged
Merged
Conversation
Owner
Author
Owner
Author
|
Merging into issue-38-cargo-runs. Linux and Windows CI pass on 3.10 and 3.13. Both macOS jobs never got a runner (no steps ran, 15-minute queue timeout, rerun queued again), so that's GitHub infra, not this code. The live Cargo-flag check is waived per DIS-169: the user confirms on first real use. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Based on
issue-38-cargo-runs(it holds #45 and #48, which aren't on main yet), so the diff is only this ticket. Retarget to main once that branch lands.What
cargo.py:get_cargo(client, character_id)readsship_item_idfrom the ship endpoint, follows asset paging, keeps only items withlocation_id= that ship and flagCargo(ammo counts, blueprint copies out), prices them with the existing market price reader, counts unpriced types, passes ESI's fetched-at through. Malformed ship/asset/price bodies raise ValueError.tk.PhotoImage(master=self, ...)in the app icon: baseline fix, the wallet-page tests failed on Linux without it.Tests
New
test_cargo.py(reader against a fake ESI client) andtest_cargo_fetch.py(GUI viagui.App, reader mocked). Full suite: 137 tests under xvfb, all pass excepttest_themefont load, which fails here only because this Linux box has no Chakra Petch font.NOT DONE: real-data check
The criterion to confirm against a live character that the hold's flag is
Cargoandlocation_idis the ship's item id is still open. It needs the Windows rig with a signed-in docked character, and the rig can't be reached from this session (no desktop access, SSH off). Don't merge until it is written up here.