perf(index): use native stream consumer and events#599
Open
Fdawgs wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the UnRTF#convert child-process event handling in src/index.js by removing the errorHandled boolean and switching to once() event listeners for "error" and "close".
Changes:
- Removed the
errorHandledflag used to suppress"close"handling after an"error"event. - Replaced
.on("error"/"close")handlers with.once("error"/"close")listeners.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fdawgs
force-pushed
the
refactor/error-flag
branch
from
July 20, 2026 17:56
ffe0c5f to
b91010a
Compare
Fdawgs
changed the title
errorHandled flag with once() listeners
Fdawgs
force-pushed
the
refactor/error-flag
branch
from
July 20, 2026 17:57
b91010a to
5efe27b
Compare
Fdawgs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaner than the
errorHandledboolean and still rejects if an abort signal is passed.Functionally the same.
Benchmarks show it to be ~2x faster.
Checklist
npm test