Repository navigation
refactor: move ihe-iti onto ihe-atna 0.2.1 and nl-generic-functions onto ferrohealth-smart 0.4.0 - #37
Merged
Merged
Conversation
…nto ferrohealth-smart 0.4.0 ihe-iti 0.0.41 drops its copies of the record bound, the URL redaction and the FHIR base join for ihe-atna's, taken through its recording and redact features. nl-generic-functions 0.0.26 takes ferrohealth-smart 0.4.0; the Nuts grant's three issuer checks stay private, as 0.4.0 lacks them. Closes #35 Closes #36
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
ihe-iti0.0.41 onihe-atna = "=0.2.1"(#35). FerroAUDIT now publishes the three helpersihe-iticarried copies of: the bound on an audited exchange's record, theDebugrendering of a URL with its credential redacted, and the URL of an interaction under a FHIR base (FerroHEALTH/FerroAUDIT#8, #9, #61). FerroFED implementsihe_atna::balp::AuditRecorderfor the recorders it hands toihe-iti's clients, so it can takeihe-atna0.2.x only onceihe-itidoes.src/recording.rs,src/redact.rsandsearch::under_baseare gone, andsearch::escapestays. Callers useihe_atna::balp::recording,ihe_atna::redactandihe_atna::fhir_base.ihe-atna/redact(url only), andxcpdalso takesihe-atna/recording(tokio and thiserror only). So a profile withoutbalporatnastill compiles no audit stack.ihe-atna0.2's API moves are applied:Coded::fixed,EventKind::subtypesas aVec, an endpoint as aNetworkAddress, and the new optional fields, written empty.ihe_iti::recordingis gone. Useihe_atna::balp::recording, whoseLateis made withLate::new().EventKindconstants are now functions (query_consumer(),match_consumer(),query(),updates(),feed_kind(),subscription_*()), because anEventKindnow holds aVec.nl-generic-functions0.0.26 onferrohealth-smart = "=0.4.0"(#36). This takes FerroFED's lock down to one copy offerrohealth-smart. 0.4.0'smetadatamodule still offers onlyissuer_urlandlocations. So the three checks the Nuts grant adds stay private innuts_auth/issuer.rs, and none is copied anywhere else:The three checks are filed in FerroSMART milestone v0.5.0.
Gates run locally:
ihe-itifeature rows and the fivenl-generic-functionsrows;No test was weakened; the test edits are the renames above.
Closes #35
Closes #36
Licensing of contributions
Checklist
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningswith and without--all-features,cargo nextest run --workspace --locked,cargo docwithRUSTDOCFLAGS=-D warnings, andcargo deny check.shellcheck --severity=style,actionlint,zizmor --min-severity=low .github/, and the self-test of every script the change touches.CHANGELOG.mdhas an[Unreleased]entry, or the change carries theno-changeloglabel.