Repository navigation
ci: keep the stray-literal guard to bash 3.2 and to a durable citation - #117
Merged
Merged
Conversation
An empty file list expands unguarded under set -u on bash 3.2, and the header cited an internal rule file; the consoles' guards caught both in their copies, which stay identical to this one.
rubentalstra
enabled auto-merge
October 19, 2026 15:44
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed and why
scripts/checks/stray-literals.shexpanded its file list unguarded, which bash 3.2 underset -ureads as unbound when the list is empty. Its header also cited an internal rule file. FerroFED'sbash-compatandcomment-styleguards caught both in that console's copy. The fix keeps the four consoles' copies identical to this one:${files[@]+"${files[@]}"}, and the header now says no specification governs the guard. No console sees a behaviour change.Licensing of contributions
Checklist
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings, the wasm32 clippy runs,cargo nextest run --workspace --locked,cargo docwithRUSTDOCFLAGS=-D warnings, andcargo deny check.docs/qa/), and the best one on its merits was restyled to the library's tokens; the winner and the reason are stated below.tests/it/states.rsin every brand, light and dark.shellcheck --severity=style,actionlint,zizmor --min-severity=low .github/.CHANGELOG.mdhas an[Unreleased]entry, if a console sees the change.