Skip to content

ci: keep the stray-literal guard to bash 3.2 and to a durable citation - #117

Merged
rubentalstra merged 1 commit into
mainfrom
ci/stray-literals-bash-3-2
Oct 19, 2026
Merged

rubentalstra merged 1 commit into
mainfrom
ci/stray-literals-bash-3-2

Conversation

@rubentalstra

Copy link
Copy Markdown
Contributor

What changed and why

scripts/checks/stray-literals.sh expanded its file list unguarded, which bash 3.2 under set -u reads as unbound when the list is empty. Its header also cited an internal rule file. FerroFED's bash-compat and comment-style guards caught both in that console's copy. The fix keeps the four consoles' copies identical to this one: ${files[@]+"${files[@]}"}, and the header now says no specification governs the guard. No console sees a behaviour change.

Licensing of contributions

  • I accept the terms in CONTRIBUTING.md § Licensing of contributions: I have the right to submit this work, I license it under the project licence of the version it lands in, and I grant the Licensor the relicensing right stated there.

Checklist

  • Accessibility decisions cite WCAG 2.2, WAI-ARIA 1.2 or the Authoring Practices, not memory and not another library.
  • Rust gates pass: cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, the wasm32 clippy runs, cargo nextest run --workspace --locked, cargo doc with RUSTDOCFLAGS=-D warnings, and cargo deny check.
  • A visible change refreshed the gallery screenshots, and I looked at every image it changed.
  • A new or changed component was compared with the four consoles' versions (docs/qa/), and the best one on its merits was restyled to the library's tokens; the winner and the reason are stated below.
  • Its interactive states (pointer, focus, open, each tone) are captured by tests/it/states.rs in every brand, light and dark.
  • A release pull request says, per screen and per state, what was checked and what was fixed.
  • Shell and workflow files are clean: shellcheck --severity=style, actionlint, zizmor --min-severity=low .github/.
  • CHANGELOG.md has an [Unreleased] entry, if a console sees the change.
  • No patient data in a fixture, test, gallery row or example.
  • Every commit is signed.
  • No AI or assistant attribution anywhere in the commits or this PR.

An empty file list expands unguarded under set -u on bash 3.2, and the
header cited an internal rule file; the consoles' guards caught both in
their copies, which stay identical to this one.
@sonarqubecloud

Copy link
Copy Markdown

@rubentalstra
rubentalstra added this pull request to the merge queue Oct 19, 2026
@rubentalstra
rubentalstra removed this pull request from the merge queue due to a manual request Oct 19, 2026
@rubentalstra
rubentalstra merged commit 45f2031 into main Oct 19, 2026
44 of 46 checks passed
@rubentalstra
rubentalstra deleted the ci/stray-literals-bash-3-2 branch October 19, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant