Repository navigation
fix: draw the footer version as data and keep the About link whole - #118
Merged
Merged
Conversation
rubentalstra
enabled auto-merge
October 19, 2026 16:10
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed and why
The two findings of the 0.1.7 pseudo-locale review (#116):
v{version}through the catalog (footer-version), so the pseudo-locale stretched it to[v0.1.7 ~~~]. The product name and its version now render as they stand in every locale. Thefooter-versionmessage and itsTextare gone, and a render test checks the version verbatim in English and in the throwawayqaalocale..fui-footer atakeswhite-space: nowrap, so at 390 px the line wraps before the link and never inside its label.Captures: the pseudo-locale pass (
FERROUI_PSEUDO=1) at 1440 and 390, light and dark, read. The footer readsFerroHEALTH UI Gallery v0.1.7 · Cadasto B.V. · [Åböüt ~~~]with the link whole at both widths; the set is mirrored to~/Downloads/ferroui-gallery-screenshots/latest/pseudo-locale/. In English the footer draws the same words and the same layout. The refreshed English images differed from main only in capture noise (the skeleton shimmer, and one layouts shot measured at a taller window), so they stay as committed.Closes #116
Licensing of contributions
Checklist
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings, the wasm32 clippy runs,cargo nextest run --workspace --locked,cargo docwithRUSTDOCFLAGS=-D warnings, andcargo deny check.docs/qa/), and the best one on its merits was restyled to the library's tokens; the winner and the reason are stated below.tests/it/states.rsin every brand, light and dark.shellcheck --severity=style,actionlint,zizmor --min-severity=low .github/.CHANGELOG.mdhas an[Unreleased]entry, if a console sees the change.