Skip to content

fix: draw the footer version as data and keep the About link whole - #118

Merged
rubentalstra merged 1 commit into
mainfrom
fix/footer-version-data
Oct 19, 2026
Merged

rubentalstra merged 1 commit into
mainfrom
fix/footer-version-data

Conversation

@rubentalstra

Copy link
Copy Markdown
Contributor

What changed and why

The two findings of the 0.1.7 pseudo-locale review (#116):

  • The version is data. The footer drew v{version} through the catalog (footer-version), so the pseudo-locale stretched it to [v0.1.7 ~~~]. The product name and its version now render as they stand in every locale. The footer-version message and its Text are gone, and a render test checks the version verbatim in English and in the throwaway qaa locale.
  • The About link never breaks inside itself. .fui-footer a takes white-space: nowrap, so at 390 px the line wraps before the link and never inside its label.

Captures: the pseudo-locale pass (FERROUI_PSEUDO=1) at 1440 and 390, light and dark, read. The footer reads FerroHEALTH UI Gallery v0.1.7 · Cadasto B.V. · [Åböüt ~~~] with the link whole at both widths; the set is mirrored to ~/Downloads/ferroui-gallery-screenshots/latest/pseudo-locale/. In English the footer draws the same words and the same layout. The refreshed English images differed from main only in capture noise (the skeleton shimmer, and one layouts shot measured at a taller window), so they stay as committed.

Closes #116

Licensing of contributions

  • I accept the terms in CONTRIBUTING.md § Licensing of contributions: I have the right to submit this work, I license it under the project licence of the version it lands in, and I grant the Licensor the relicensing right stated there.

Checklist

  • Accessibility decisions cite WCAG 2.2, WAI-ARIA 1.2 or the Authoring Practices, not memory and not another library.
  • Rust gates pass: cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, the wasm32 clippy runs, cargo nextest run --workspace --locked, cargo doc with RUSTDOCFLAGS=-D warnings, and cargo deny check.
  • A visible change refreshed the gallery screenshots, and I looked at every image it changed.
  • A new or changed component was compared with the four consoles' versions (docs/qa/), and the best one on its merits was restyled to the library's tokens; the winner and the reason are stated below.
  • Its interactive states (pointer, focus, open, each tone) are captured by tests/it/states.rs in every brand, light and dark.
  • A release pull request says, per screen and per state, what was checked and what was fixed.
  • Shell and workflow files are clean: shellcheck --severity=style, actionlint, zizmor --min-severity=low .github/.
  • CHANGELOG.md has an [Unreleased] entry, if a console sees the change.
  • No patient data in a fixture, test, gallery row or example.
  • Every commit is signed.
  • No AI or assistant attribution anywhere in the commits or this PR.

@rubentalstra rubentalstra added this to the v0.2.0 milestone Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rubentalstra
rubentalstra added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit ada896c Oct 19, 2026
26 checks passed
@rubentalstra
rubentalstra deleted the fix/footer-version-data branch October 19, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The version number and a link label are treated as translatable text

1 participant