Skip to content

fix(ci): restore the release milestone check and close that #126 removed (#128) - #129

Merged
rubentalstra merged 1 commit into
mainfrom
fix/restore-release-milestone-check
Oct 19, 2026
Merged

rubentalstra merged 1 commit into
mainfrom
fix/restore-release-milestone-check

Conversation

@rubentalstra

Copy link
Copy Markdown
Contributor

What changed and why

#126 squashed in a stale copy of the release files from a branch cut before #125 merged, which removed all of #125. This restores #125's files as they merged:

  • scripts/release/milestone.sh;
  • its check and close steps in release.yml;
  • the CI self-test in ci.yml;
  • the matching text in ci-cd.md, issue-workflow.md and the two memory files.

#126's own changes to ci.yml (the gallery stray-literal root) and leptos-ui.md stay. Running git diff dfbf84a on the restored paths shows only those.

The v0.2.0 release (run 39325940406) ran without the check and left milestone v0.2.0 open. I closed it with milestone.sh close v0.2.0, which checked that it was empty first.

No console sees this change, so it has no changelog entry.

Closes #128

Licensing of contributions

  • I accept the terms in CONTRIBUTING.md § Licensing of contributions: I have the right to submit this work, I license it under the project licence of the version it lands in, and I grant the Licensor the relicensing right stated there.

Checklist

  • Shell and workflow files are clean: shellcheck --severity=style; milestone.sh --self-test passes.
  • Every commit is signed.
  • No AI or assistant attribution anywhere in the commits or this PR.

@rubentalstra rubentalstra added the no-changelog PR escape hatch: the change has no effect a console sees. label Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rubentalstra
rubentalstra added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit d10da09 Oct 19, 2026
26 checks passed
@rubentalstra
rubentalstra deleted the fix/restore-release-milestone-check branch October 19, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog PR escape hatch: the change has no effect a console sees.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The release milestone check and close were removed by a later squash

1 participant