Repository navigation
Layer 1 Scroll actions, panned-view fix and live config switching (0.91.6-0.91.16) - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 1 Scroll/WM actions from the TODO, a Scroll view fix, and runtime config switching. Versions 0.91.6 to 0.91.16, one milestone per commit, each with CHANGELOG/DEV_CHANGELOG/DOCUMENTATION in sync and the four gates passing (749 tests at the end: 717 + 23 + 9).
Fixes
repair_keyboard_focusprefers the most recent visiblefocus_historywindow on the output before the old topmost-Spacefallback (niri's activate-previous-column). Withfocus_follows_mouse, the window under the pointer still wins first, unchanged. Real-protocol regression test that fails on the old code.reveal_scroll_window(focus), snapping a deliberate pan back to the focused column; the offset itself survived Ocean. Both now usereveal_scroll_window_unless_panned. Focus-driven reveals are unchanged.load-config-filekeeps symlinks (0.91.16). Canonicalizing a symlinkedconfig.wavemade its relative includes resolve next to the link target. Paths are now made absolute without resolving symlinks.New actions
reload-config,tidectl reloadload-config-file:<path>,tidectl load-config <file>move-column-to-index:<n>0rejectedcenter-visible-columnsset-window-height:<v>,reset-window-height,switch-preset-height(-back),scroll.preset_heightsmove-column-to-workspace:<n|name>Layouts::removeforgetsfocus-floating,focus-tiling,switch-focus-between-floating-and-tilingtoggle-keyboard-shortcuts-inhibitSmallvil::keybind_table)toggle-touchpadCONFIG_PATH_OVERRIDEis now anRwLock<Option<PathBuf>>instead of a once-setOnceLock; startup-cbehaves as before.Verification
load-configwith a copy, a broken file and the real symlinked config.tidectl doctor11/11 after each step.Not verified
toggle-touchpadandtoggle-keyboard-shortcuts-inhibit: parse tests only (no touchpad or inhibiting client on the test machine).center-visible-columns: the action ran natively, but the centred position was not checked visually.toggle-window-urgent(focus clears urgency, so it cannot persist on the focused window).