Add fast Foundry profile - #303
Merged
Merged
Conversation
Add a non-IR, unoptimized profile with isolated artifacts for faster local builds and tests. Refactor stack-heavy verifier paths so the standard pipeline compiles, make storage-read assertions portable across compiler settings, and wire the profile through Make, documentation, and CI. Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Contributor
|
I think the reason for the other changes is to fix the stack-too-deep error. If we could fix that everywhere, we could actually run |
Collaborator
Author
|
Yes, it resolves |
Collaborator
Author
|
|
wjmelements
reviewed
Aug 17, 2026
wjmelements
reviewed
Aug 17, 2026
Comment on lines
+605
to
+606
| // forge-lint: disable-next-line(asm-keccak256) | ||
| bytes32 targetHash = keccak256(pieceCid.data); |
Contributor
There was a problem hiding this comment.
create issue to fix asm-keccak256. solidity isn't very good at this kind of thing
Collaborator
Author
There was a problem hiding this comment.
I was looking at it and it is really ugly, so I decided not to pursue it.
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
wjmelements
reviewed
Aug 17, 2026
wjmelements
approved these changes
Aug 17, 2026
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
wjmelements
reviewed
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fast Foundry profile for local development while retaining optimized IR for production builds.
Changes
profile.fastwith IR and optimizer disabled.make build-fastandmake test-fast.out-fast/andcache-fast/directories.PDPVerifierpaths so non-IR compilation succeeds.Performance
Clean full-suite time: