Skip to content

fix(frontend): enforce start > now and start < end client-side validation in CreateCampaign (#1474) #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryder777777 wants to merge 1 commit into from
Closed

fix(frontend): enforce start > now and start < end client-side validation in CreateCampaign (#1474) #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions frontend/src/lib/validateCampaignForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,17 @@ export function validateCampaignForm(values, { isEditMode = false, now = new Dat

const start = values.startDate ? new Date(values.startDate) : null;
const end = values.endDate ? new Date(values.endDate) : null;
if (start && Number.isNaN(start.getTime())) errors.startDate = 'Start date is invalid.';
if (start && Number.isNaN(start.getTime())) {
errors.startDate = 'Start date is invalid.';
} else if (start && !isEditMode && start.getTime() <= now.getTime()) {
errors.startDate = 'Start date must be in the future.';
}
if (end && Number.isNaN(end.getTime())) {
errors.endDate = 'End date is invalid.';
} else if (end) {
if (!isEditMode && end.getTime() <= now.getTime()) {
errors.endDate = 'End date must be in the future.';
} else if (start && !errors.startDate && end.getTime() <= start.getTime()) {
} else if (start && !Number.isNaN(start.getTime()) && end.getTime() <= start.getTime()) {
errors.endDate = 'End date must be after the start date.';
}
}
Expand Down