fix(FB_MESSAGE): Use correct SQL types for FB_DATE and FB_TIME#9064
Open
TreeHunter9 wants to merge 1 commit into
Open
fix(FB_MESSAGE): Use correct SQL types for FB_DATE and FB_TIME#9064TreeHunter9 wants to merge 1 commit into
FB_MESSAGE): Use correct SQL types for FB_DATE and FB_TIME#9064TreeHunter9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have accidentally found that
FB_DATEis unfolding into:Where 510 is
SQL_TIMESTAMP, andsizeof(::Firebird ::FbDate)is 4. It creates mismatch in offsets between metadata and data buffer (message buffer), that can lead to unpredictable result (I have seen a insert data has been corrupted andNULLwas inserted instead of real data).And
FB_TIMEuses a non-existent SQL type.