Skip to content

fix(serializing): write null for despawned NetworkObject references #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxkratt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(serializing): write null for despawned NetworkObject references #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Assets/FishNet/Runtime/Serializing/Writer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,17 @@ public void WriteNetworkObject(NetworkObject nob)
return;
}

/* NetworkManager is assigned when a NetworkObject initializes
* and is never cleared by ResetState, so if it is set this object
* was previously spawned and is now despawning/despawned (or pooled).
* Send a null reference rather than falling back to PrefabId, which
* the reader would resolve to the prefab template instead of null. */
if (nob.NetworkManager != null)
{
WriteNullReferenceId();
return;
}

WriteNetworkObjectId(nob.PrefabId);
}
else
Expand Down