feat(Segment membership): Refresh membership counts on segment edit#7828
Open
khvn26 wants to merge 1 commit into
Open
feat(Segment membership): Refresh membership counts on segment edit#7828khvn26 wants to merge 1 commit into
khvn26 wants to merge 1 commit into
Conversation
Wire the per-project segment membership count refresh into the segment create, update, clone and LaunchDarkly import paths via a new `enqueue_membership_refresh` service, so edits refresh counts within minutes instead of waiting for the daily backfill. The service debounces per project and no-ops when the feature flag is off. beep boop
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
github-actions
Bot
added
api
Contributor
Docker builds report
|
khvn26
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7828 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 1465 1466 +1
Lines 56889 56974 +85
=======================================
+ Hits 56082 56167 +85
Misses 807 807 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression19 screenshots compared. See report for details. |
emyller
approved these changes
Jun 18, 2026
emyller
left a comment
emyller
left a comment
Contributor
There was a problem hiding this comment.
I'd love to see suggested improvements to tests, though none are blocking if you need to proceed.
Comment on lines
+21
to
+34
| url = reverse( | ||
| "api-v1:projects:project-segments-detail", | ||
| args=[project, segment], | ||
| ) | ||
| data = { | ||
| "name": "renamed", | ||
| "project": project, | ||
| "rules": [{"type": "ALL", "rules": [], "conditions": []}], | ||
| } | ||
|
|
||
| # When | ||
| response = admin_client.put( | ||
| url, data=json.dumps(data), content_type="application/json" | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| url = reverse( | |
| "api-v1:projects:project-segments-detail", | |
| args=[project, segment], | |
| ) | |
| data = { | |
| "name": "renamed", | |
| "project": project, | |
| "rules": [{"type": "ALL", "rules": [], "conditions": []}], | |
| } | |
| # When | |
| response = admin_client.put( | |
| url, data=json.dumps(data), content_type="application/json" | |
| ) | |
| # When | |
| response = admin_client.put( | |
| f"/api/v1/projects/{project}/segments/{segment}/", | |
| data={ | |
| "name": "renamed", | |
| "project": project, | |
| "rules": [{"type": "ALL", "rules": [], "conditions": []}], | |
| }, | |
| format="json", | |
| ) |
Similar improvements can be made throughout this patch.
| ) | ||
|
|
||
| # When | ||
| # the import (which bulk-creates segments) completes |
Contributor
There was a problem hiding this comment.
Suggested change
| # the import (which bulk-creates segments) completes |
| process_import_request(import_request) | ||
|
|
||
| # Then | ||
| # it triggers a single membership refresh for the imported project |
Contributor
There was a problem hiding this comment.
Suggested change
| # it triggers a single membership refresh for the imported project |
Contributor
There was a problem hiding this comment.
Not sure if LLM-generated, but I don't see value in the extra GWT lore throughout this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7470.
In this PR, we wire the per-project segment membership count cache refresh into the segment edit paths. The daily backfill stays as the safety net for projects whose segments aren't edited.
A new
enqueue_membership_refresh(project)service queuesrefresh_project_segment_countsfor a project with a debounce to protect against rapid successive edits.It's called from each path that creates or edits a canonical segment:
SegmentSerializer.create)SegmentSerializer.update)cloneviewset action)process_import_requestcompletes)Segment deletion is left to the daily backfill, which prunes stale count rows.
How did you test this code?
Added new tests:
enqueue_membership_refreshcovering the flag gate, the per-project debounce, and that an enqueued refresh runs end to end.