Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of SEO meta translations across the frontend by introducing a new
translateMetafunction that ensures no untranslated i18n keys appear in SEO tags, and by updating how the language is resolved for meta generation. It also updates all static and dynamic pages to use this safer translation method for their meta titles and descriptions.SEO Meta Translation Improvements:
translateMetatoseo-meta.ts, which guarantees that meta translations never return raw i18n keys and always fallback to a supported language or an empty string if no translation is available. This prevents untranslated keys from appearing in SEO-relevant tags.siteTitleand all usages of meta descriptions and titles in static and dynamic pages to usetranslateMetainstead of the regulartranslatefunction, ensuring consistent and safe SEO strings. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Language Resolution Consistency:
resolveMetaLanguagefunction to correctly extract the language fromloaderData(notdata) in React Router matches, and to validate that the resolved language is supported, defaulting to French if not. [1] [2]Refactoring and Consistency:
LegalNotice,Privacy,Terms,Compare,Home,ServerDetail,root.tsx) to consistently use the new translation and language resolution utilities. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]