Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new mechanism for synchronizing client-side document metadata (title and meta tags) with the current route and language, improving SEO and user experience. It standardizes how page metadata is defined and applied across the app, and refactors all major pages to use this new system.
Client-side document meta synchronization:
DocumentMetaSynccomponent that automatically applies the correcttitleand meta descriptions on the client by traversing route handles for agetDocumentMetafunction. This ensures metadata stays up-to-date with navigation and language changes. (frontend/app/ui/layout/DocumentMetaSync.tsx,frontend/app/ui/layout/index.tsx) [1] [2]Metadata definition and application API:
DocumentMetaandRouteMetaHandletypes, and anapplyDocumentMetafunction to standardize and simplify how pages declare and apply their metadata. (frontend/app/core/lib/seo-meta.ts)Page-level refactoring to use new metadata system:
Home,Compare,LegalNotice,Privacy,Terms,ServerDetail) to export ahandlewith agetDocumentMetafunction, and to use the newDocumentMetastructure for metadata. This replaces ad hoc or inline meta tag generation. (frontend/app/pages/home/index.tsx,frontend/app/pages/compare/index.tsx,frontend/app/pages/LegalNotice.tsx,frontend/app/pages/Privacy.tsx,frontend/app/pages/Terms.tsx,frontend/app/pages/server-detail/index.tsx) [1] [2] [3] [4] [5] [6] [7] [8]Code cleanup and documentation:
seo-meta.tsto streamline the code and documentation. [1] [2] [3]Type and import updates:
This refactor lays the groundwork for robust, language-aware SEO and consistent metadata management across the application.