Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the server favicon override functionality in the admin UI by making the favicon state more reliable, preventing stale image previews, and enhancing the user experience for uploading or removing favicons. The changes also add a new field to the server schema to better track favicon overrides.
Favicon override improvements:
UpdateFaviconModalnow relies on the newforced_faviconfield rather thanlast_favicon, ensuring accurate detection of whether a server has a custom favicon. [1] [2]faviconCacheVersionvariable that increments after each successful favicon update, forcing the browser to fetch the latest icon and preventing stale preview images due to cache. [1] [2] [3]Schema update:
forced_faviconboolean field to theServerSchemato reliably indicate if a server has a custom favicon override.UI/UX enhancements:
These changes make favicon management in the admin interface more robust and user-friendly.