Repository navigation
S2: record an actuator status that arrived before any system description - #287
Merged
Merged
Conversation
…escription After a reconnection, a resource manager can send its actuator status before its system description. Only a description says what power an operation mode stands for, so such a status was logged and skipped, and the power sensor showed nothing until the next status. It is now kept, the latest per actuator, and recorded once a description arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcpawsJs74cSwFLXkz7ZwW Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcpawsJs74cSwFLXkz7ZwW Signed-off-by: F.N. Claessen <claessen@seita.nl>
Coverage Report for CI Build 42648463298Warning No base build found for commit Coverage: 95.943%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Flix6x
added a commit
that referenced
this pull request
Nov 9, 2026
…ensor Signed-off-by: F.N. Claessen <claessen@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on a review comment on #283: keep an actuator status that arrives before any system description, and process it once one arrives, instead of dropping it.
Why
After a reconnection, a resource manager can send its
FRBC.ActuatorStatusbefore itsFRBC.SystemDescription. Only the description says what power an operation mode stands for, so #274 logged such a status and skipped it, rather than raising in a background task. The power sensor then showed nothing until the resource manager sent its next status, which for a device that does not switch can take a long time.What
FRBCkeeps, per actuator, the latest status that arrived before any description (_statuses_awaiting_a_description). Only the latest matters, since a status describes the actuator's present state.FRBCSimple.send_actuator_statuskeeps the status instead of only logging it, at info level rather than as a warning, since nothing is lost any more.The TUNES handler overrides
handle_system_descriptionand records no actuator power, so it keeps nothing and is unaffected.Evidence
🤖 Generated with Claude Code
https://claude.ai/code/session_01CcpawsJs74cSwFLXkz7ZwW