Repository navigation
Conversation
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
…eedup to config Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
… still have multiple workers Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
…es sensor with OpenADR beliefs Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ec5cc4c to
6654eab
Compare
There was a problem hiding this comment.
It looks like these .github instructions are copied from the flexmeasures repo. I think it would make sense to view these as being applicable to the FM server and all FM plugins (basically FlexMeasures organization-wide). I see 3 ways forward:
- Keep the files in
flexmeasuresonly, and have plugins (including theflexmeasures-plugin-templaterepo) point to them in theirAGENTS.md. Not sure if agents will respect that. - Move the files to the
tsc(or a new dedicated) repo under the FlexMeasures organization. Same uncertainty as 1. - Have them duplicated in each plugin, and keep them in sync (perhaps through a dedicated test in the plugin, against the instructions set in the
flexmeasuresrepo). - Have them duplicated in each plugin; accept diverging.
Do you want to try 1, which would be my preference? I'm afraid you happen to be the first plugin author to face this issue.
|
|
||
| Every profile is drawn from a generator seeded on the sensor and the local calendar day, | ||
| and each day is generated whole before being cut back to the window. A given day therefore | ||
| always gets the same numbers, whether the script runs at dawn or at noon, and a re-run |
There was a problem hiding this comment.
runs at confused me. Is the seed based on the day at which:
- the user runs the script,
- the
belief_timeof the forecasts reside in, or - the events that are being forecast reside in?
If it is 2, then I suggest:
| always gets the same numbers, whether the script runs at dawn or at noon, and a re-run | |
| always gets the same numbers, whether the forecaster runs at dawn or at noon, and a re-run |
| SQLALCHEMY_DATABASE_URI: postgresql://fm-walkthrough-user:fm-walkthrough-pass@fm-db:5432/fm-walkthrough-db | ||
| FLEXMEASURES_REDIS_URL: queue-db | ||
| FLEXMEASURES_REDIS_PASSWORD: fm-redis-pass | ||
| SECRET_KEY: notsecret | ||
| SECURITY_TOTP_SECRETS: '{"1": "something-secret"}' | ||
| FLEXMEASURES_ENV: development | ||
| FLEXMEASURES_PLUGINS: flexmeasures_openadr3 | ||
| ALLOW_INSECURE_HTTP_VTN: "true" | ||
| OAUTHLIB_INSECURE_TRANSPORT: "1" | ||
| OAUTHLIB_RELAX_TOKEN_SCOPE: "1" | ||
| LOGGING_LEVEL: INFO |
There was a problem hiding this comment.
I suggest refactoring to share a single definition of the environment settings across 4 services.
nhoening
left a comment
There was a problem hiding this comment.
For the record, I ran this myself (mostly successful), and send Nick my comments per email a few days ago. Also, Nick showed this demo successfully at the LF Energy Summit this week.
I'm still tweaking the demo in the coming days, but it is E2E working. I'm still not a fan of the clarity of the comparison chart, but i'll keep churning on that.
For now, the flexmeasures setup in the example/demo looks as follows:
With a combination of flexible/inflexible loads,
The demo scenario is configured to initially only generate a plan (with only pricing input) and afterwards generate a plan with both pricing and OpenADR input.
The comparison chart/html currently looks as follows (this part is still WIP):
comparison.html