Repository navigation
Ship ECharts' NOTICE file with its licence - #2747
Merged
Merged
Conversation
A library can now record notice files, which its licence requires to be shipped along. They are fetched and hash-checked like its licence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bawYg67N5T5csiFdwWgZ1 Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bawYg67N5T5csiFdwWgZ1 Signed-off-by: F.N. Claessen <felix@seita.nl>
Documentation build overview
5 files changed ·
|
…2746) The background fetch's lock test now also counts the fake library's notice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bawYg67N5T5csiFdwWgZ1 Signed-off-by: F.N. Claessen <felix@seita.nl>
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #2711, the Docker image ships the UI's libraries, each with its licence. ECharts is Apache-2.0, which also requires its
NOTICEfile to travel with redistributed copies (§4(d)), and we only shipped itsLICENSE.notices: further files its licence requires to be shipped along. They are fetched and checked against their hashes like the licence, and stored next to it.NOTICE.FLEXMEASURES_JS_VERSIONS, notices are fetched without a hash, like its licence, and a missing one only logs a warning.--print-hashesalso prints the notices' hashes.documentation/changelog.rstI checked the licences of all the libraries we ship: they are MIT, BSD, Apache-2.0 (ECharts) and SIL OFL 1.1 (the Poppins and Font Awesome fonts). ECharts is the only one with a
NOTICEfile.How to test
pytest flexmeasures/ui/tests/test_vendor_assets.py. Each new assertion fails when the behaviour it covers is broken.python -m flexmeasures.ui.utils.fetch_vendor_assets, then look forflexmeasures/ui/static/vendor/echarts/5.6.0/NOTICE.Related Items
#2711, #2718
🤖 Generated with Claude Code
https://claude.ai/code/session_019bawYg67N5T5csiFdwWgZ1