Repository navigation
Move Contact Support into the core package - #13
Merged
Merged
Conversation
Apps of every category have a support channel, yet the action was only available after importing TranslateKitMedical. It now lives in the core TranslateKit module with its existing translations; category modules re-export the core, so 'import TranslateKitMedical' still finds it.
Apple's support app says 'Contacter l’assistance' in Canadian French as well, shorter than the previous 'Communiquer avec le service d’assistance'. Italian gets the typographic apostrophe Apple uses.
The test does not compile against the previous layout, which is exactly the error from the issue, and passes once the action is in the core.
Jeehut
force-pushed
the
wip/contact-support-in-core
branch
from
October 12, 2026 09:31
ec4e4d1 to
ae7a5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6.
TK.Action.contactSupportwas only reachable after importingTranslateKitMedical, although nearly every app has a support channel. It now lives in the coreTranslateKitmodule, together with all of its 40 translations; the entry was moved as it was between the two catalogs.Code that imported
TranslateKitMedicalkeeps compiling, because every category module re-exports the core. Code that only importsTranslateKit(as in the issue) now finds the action. Since 2.0 is a major release anyway, there is no deprecated forwarder left behind in Medical – it would only shadow the core property.A second commit aligns two languages with Apple's own button in the support flow: fr-CA was "Communiquer avec le service d’assistance" and is now "Contacter l’assistance", as in Apple's apps; Italian gets the typographic apostrophe ("Contatta l’assistenza"). The other languages already matched Apple or keep the package's form for buttons.
How this was verified
ContactSupportTestschecks the property from a plainimport TranslateKitand reads the compiled core bundle for missing languages. Against the sources onmainit fails to compile with the error from the issue; on this branch it passes:Tests/TranslateKitTests/CompiledCatalog.swiftis the same helper as in #12; whichever PR lands second merges it without a conflict.