Skip to content

security: Add Stellar ed25519 address checksum validation on frontend #143

Closed

Description

@Austinaminu2

Description

The current frontend address validation only checks that the recipient address starts with G and has a length of 56 characters. This is insufficient — Stellar G-addresses include a CRC-16 checksum in the last 2 bytes of the base32-decoded value.

Without checksum validation, a user who mistypes a single character could send a stream to a non-existent address with no warning, permanently locking those funds.

Current Behavior

// Simplified current check
const isValid = address.startsWith('G') && address.length === 56;

Expected Behavior

Validate the full Stellar address including:

  • Correct base32 encoding
  • Valid ed25519 public key prefix (version byte 0x30)
  • CRC-16 checksum match

The Stellar SDK's StrKey.isValidEd25519PublicKey() already provides this.

Acceptance Criteria

  • Use StrKey.isValidEd25519PublicKey() from @stellar/stellar-sdk for address validation
  • Show specific error messages: "Invalid checksum" vs "Invalid format"
  • Validate on the create stream form, batch upload, and address book
  • Add unit tests for valid, invalid, and near-miss addresses

Activity

  1. ranjeet150 commented on Oct 6, 2026

    @ranjeet150

    Hi team,

    Happy to tackle this. Here is how I plan to implement it:

    Implementation approach:

    1. Audit authorization boundaries and enforce defensive validation barriers.
    2. Implement multi-role permission checks and invocation validation.
    3. Write adversarial unit tests simulating edge failure modes and invalid callers.
    4. Ensure zero regressions across existing test suites and CI workflows.

    Could you please assign this issue to me? Looking forward to delivering a clean PR.

  2. olacodes-01 commented on Oct 18, 2026

    @olacodes-01

    @olacodes-01 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I have reviewed this issue and I have relevant experience in solving it. Please assign to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @olacodes-01 to this issue.

  3. christabel888 commented on Oct 18, 2026

    @christabel888
    Contributor

    @christabel888 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I have reviewed this issue and I have relevant experience in solving it. Please assign to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @christabel888 to this issue.

  4. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @christabel888! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @christabel888: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. grantfox-oss commented on Oct 18, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @christabel888's PR #1028 was approved and merged by @Austinaminu2.

    🏆 @christabel888: You earned 35 FoxPoints for this contribution! Your current tier: Builder (1,025 total points). Track your full progress on GrantFox.

    👏 Great work, @christabel888! Keep contributing to FlowwStar.

  6. drips-wave commented on Oct 18, 2026

    @drips-wave

    This issue has been completed by @christabel888 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @christabel888: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  7. added a commit that references this issue on Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programfrontendNext.js frontendsecuritySecurity improvements

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions