Repository navigation
cef_host: point the resize capture refresh at CEF issue #3826 - #63
Merged
Merged
Conversation
The capturer's retries never capture after a dropped frame because Chromium's FrameSinkVideoCapturerImpl::MaybeDeliverFrame doesn't call VideoCaptureOracle::CompleteCapture for it, so num_frames_pending_ stays up and every kRefreshRequest is refused (CEF issue #3826). That is the "nothing pending" check our trace showed rejecting them. CEF fixed it with viz_capture_3826.patch on branch 8037 and master; we're on 7559. Say so, and when the refresh can go. Comment and changelog only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment and changelog only. The prebuilt isn't published yet, so it goes in first.
The stall behind #61 is upstream CEF issue #3826. Chromium's
FrameSinkVideoCapturerImpl::MaybeDeliverFramedoesn't callVideoCaptureOracle::CompleteCapturefor a dropped frame.num_frames_pending_therefore stays up, and every capturer-sidekRefreshRequestretry is refused. That is the "nothing pending" rejection ourgpu.capturetrace showed.Invalidate(PET_VIEW)(kRefreshDemand) bypasses the check. It's the workaround used in that thread and by other embedders.CEF fixed it in 0d05970 with
viz_capture_3826.patch, on branch 8037 and master. We're on 7559. The comment now says the refresh can go once we're on such a CEF.🤖 Generated with Claude Code