Repository navigation
fix(base): UnorderedMap inserts no longer duplicate a key past a tombstone - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operator[], insert and emplace claimed the first tombstone on the probe chain without checking whether the key sat further along it. After an erase, re-inserting a colliding key stored it twice; size() grew and a later erase left the stale copy findable.
The insert paths now share one probe that runs to an empty slot and only then reuses the first tombstone. Reusing a tombstone also decrements tombstone_count_, which was never done, so the map rehashed early.
UnorderedSet wraps UnorderedMap and is fixed with it. Three regression tests fail before and pass after.