Repository navigation
Build a String from a view by data(), not c_str() - #25
Merged
Merged
Conversation
A StringRef satisfies HasStringTraits, so it took the c_str() constructor, and a slice of a longer string is not null-terminated: debug builds trapped. rx's vfs hit it on every mount point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String(const StringRef&) went through the HasStringTraits constructor, which copied via c_str(); a StringRef slice is not null-terminated, so Debug builds trapped (rx's vfs hit it on every mount point). New test ConstructsFromAnUnterminatedSlice; 1052 base tests pass in Debug.