Repository navigation
base: one Option/Feature registry per process in shared-object builds - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InitChain<T>::root()keeps the chain head in a function-local static of a class template. A project that builds its modules as shared objects with-fvisibility=hidden(rx's component build) instantiates that template in every .so, and each gets its own hidden root. AnOptionregistered in one .so is then invisible toOptionBase::VisitAllin another. rx hit this: a platform config's[options]entries resolved only for options declared in the one .so doing the lookup.BASE_SHARED_REGISTRYputs default visibility onInitChain,OptionBaseandFeature. An instantiation is only as visible as its template argument, so both item types need it, not just the template. The root then becomes an ELF-unique symbol (uinnm), one per process. Static builds are unaffected.PE has no unique binding; on Windows base would have to be a DLL for the same guarantee. The comment says so.
Verified from rx: the root is
uinlibrx_render.so, and an[options]file naming options from five different .so files resolves all of them (before: four unresolved).