Repository navigation
Bump equilibrium for the const Function fix - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up Force67/equilibrium#21. Renderer::BuildFrameGraph captures each scene hook by copy in the pass lambda; moving that lambda moved the capture as a const Function&&, which base::Function wrapped in another Function without bound until the stack overflowed. Any app registering a scene hook crashed on its first windowed frame (anyvoxel did;
rx --demo scenehooknow runs too).ctest 152/152 under vkrun, all seven runtime/scenes captures pass rxdiff, schema/materials/validate identical.