You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preserve Array protocol for single-point plane and spherical calls
src/mach/wavefront.py:25
The new return checks reject valid single-point NumPy calls to both plane and spherical (without aperture bounds). When points_m.shape == (3,), xp.vecdot and _spherical_distance return NumPy scalars, which lack methods required by the Array protocol, including __dlpack_device__. The decorators therefore raise TypeCheckError after computing valid distances. Wrap plane's return value and _spherical_distance's final expression with xp.asarray, and add NumPy single-point regressions for both APIs; the array-api-strict tests miss these cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
make check164 passed, 2 skipped