Skip to content

Support variadic element dimensions - #84

Merged
charlesbmi merged 2 commits into
mainfrom
feature/variadic-element-dimensions
Oct 23, 2026
Merged

charlesbmi merged 2 commits into
mainfrom
feature/variadic-element-dimensions

Conversation

@charlesbmi

Copy link
Copy Markdown
Collaborator

Summary

  • use jaxtyping named variadic axes to bind matching element dimensions
  • flatten multidimensional element layouts before chunked reduction
  • test multidimensional layouts and reject mismatched leading shape tuples

Testing

  • 31 wavefront tests passed using the Python-only test harness
  • ruff check src/mach/wavefront.py tests/test_wavefront.py
  • ruff format --check src/mach/wavefront.py tests/test_wavefront.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The public function still silently accepts mismatched leading element shapes without the test-only runtime type wrapper.

1 open finding
What changed in this PR

Adds support for multidimensional element layouts in earliest-arrival calculations.

Changes:

  • Binds matching variadic element dimensions.
  • Flattens element layouts before chunked reduction.
  • Adds multidimensional and mismatched-shape tests.
File Description
src/​mach/​wavefront.py Supports variadic element dimensions and flattened processing.
tests/​test_wavefront.py Tests multidimensional layouts and shape mismatch rejection.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/mach/wavefront.py Resolved
charlesbmi and others added 2 commits October 23, 2026 14:14
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@charlesbmi
charlesbmi force-pushed the feature/variadic-element-dimensions branch from 5425a2f to b210e75 Compare October 23, 2026 21:21
@charlesbmi
charlesbmi merged commit 0505f70 into main Oct 23, 2026
3 checks passed
@charlesbmi
charlesbmi deleted the feature/variadic-element-dimensions branch October 23, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants