Repository navigation
Support variadic element dimensions - #84
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The public function still silently accepts mismatched leading element shapes without the test-only runtime type wrapper.
1 open finding
What changed in this PR
Adds support for multidimensional element layouts in earliest-arrival calculations.
Changes:
- Binds matching variadic element dimensions.
- Flattens element layouts before chunked reduction.
- Adds multidimensional and mismatched-shape tests.
| File | Description |
|---|---|
src/mach/wavefront.py |
Supports variadic element dimensions and flattened processing. |
tests/test_wavefront.py |
Tests multidimensional layouts and shape mismatch rejection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
charlesbmi
force-pushed
the
feature/variadic-element-dimensions
branch
from
October 23, 2026 21:21
5425a2f to
b210e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
ruff check src/mach/wavefront.py tests/test_wavefront.pyruff format --check src/mach/wavefront.py tests/test_wavefront.py