AC-940 fix forest-express-sequelize ReDoS finding - #1143
Open
AlexandreFauchard wants to merge 2 commits into
Open
AC-940 fix forest-express-sequelize ReDoS finding#1143AlexandreFauchard wants to merge 2 commits into
AlexandreFauchard wants to merge 2 commits into
Conversation
Refs AC-948. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegExpconstruction in record search decoration with case-insensitive literal substring matching.Test plan
yarn install --frozen-lockfileyarn lint(passes with existing warnings)yarn buildyarn test --runInBand(fails: existing DB connection failures for integration suites and unrelated query-options failures)Made with Cursor
Note
Fix ReDoS vulnerability in
decorateForSearchby replacing regex matching withtoLowerCase().includesrecords-decorator.jswith ahasCaseInsensitiveMatchhelper that usestoLowerCase().includes, eliminating the ReDoS risk from user-controlled search strings being passed tonew RegExp.search-builder.jsso that smart fieldsearchhandlers can return a modified query object; the returned value is now reassigned and passed forward instead of being discarded.Macroscope summarized ab7525d.