Skip to content

test(journey-app): support signalsInitializationOptions for protect test - #758

Open
ancheetah wants to merge 1 commit into
mainfrom
aj-fix-am-protect-test
Open

test(journey-app): support signalsInitializationOptions for protect test#758
ancheetah wants to merge 1 commit into
mainfrom
aj-fix-am-protect-test

Conversation

@ancheetah

Copy link
Copy Markdown
Collaborator

JIRA Ticket

None

Description

Fixes the Protect component in the journey-app to support signalsInitializationOptions. When signalsInitializationOptions are returned in a PingOneProtectInitializationCallback they are given priority over the standard config. These options may not contain an envId but the journey should still complete successfully without it.

The Protect test in our journey e2e test suites runs against the mock api only so we didn't catch this. When running against a live tenant with signalsInitializationOptions this test will fail with out this fix.

Up for discussion: Should we add an additional test for signalsInitializationOptions? And should it use the mock api or a live tenant?

@changeset-bot

changeset-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ede4600

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 980e7a47-1f37-4845-81ed-7f483670253f


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit ede4600

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded 1s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 2m 8s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-26 20:54:43 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@758

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@758

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@758

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@758

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@758

@forgerock/recognize

pnpm add https://pkg.pr.new/@forgerock/recognize@758

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@758

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@758

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@758

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@758

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@758

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@758

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@758

commit: ede4600

@github-actions

Copy link
Copy Markdown
Contributor

Deployed 948405f to https://ForgeRock.github.io/ping-javascript-sdk/pr-758/948405f9f0899032c28ae363dec071a23a3f34ac branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 92.6 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/device-client - 10.0 KB (new)
🆕 @forgerock/device-client - 0.0 KB (new)

➖ No Changes

@forgerock/sdk-utilities - 18.6 KB
@forgerock/recognize - 4284.4 KB
@forgerock/sdk-request-middleware - 4.6 KB
@forgerock/iframe-manager - 3.2 KB
@forgerock/sdk-oidc - 5.7 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/oidc-client - 35.4 KB
@forgerock/sdk-types - 9.1 KB
@forgerock/davinci-client - 59.6 KB
@forgerock/protect - 144.6 KB


15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant