Skip to content

Redact auth and payment bodies in HTTP logs - #301

Merged
karagozemin merged 2 commits into
Fortexa-stellar:mainfrom
emrekayat:issue-235-http-redact
Oct 1, 2026
Merged

karagozemin merged 2 commits into
Fortexa-stellar:mainfrom
emrekayat:issue-235-http-redact

Conversation

@emrekayat

Copy link
Copy Markdown
Contributor

Closes #235

Summary

  • HTTP logs for login, decision, and submit redact request and response bodies while keeping method, path, and status.
  • Passwords, challenges, memos, signatures, and signed XDR are removed from those bodies.
  • A body that failed the size limit is not written to the log.

Test plan

  • A fixture secret in a login body is absent from the log.
  • Signed XDR is absent from the submit log.
  • Status and path remain.
  • An oversized body is omitted.
  • Tests call the logger directly and do not start a server.
  • vitest run on the HTTP and redact observability tests.

Made with Cursor

Login, decision, and submit logs keep the method, path, and status, while secrets, signatures, and signed XDR are redacted and an oversized body is left out of the log.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 01:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@drips-wave

drips-wave Bot commented Oct 1, 2026

Copy link
Copy Markdown

@emrekayat Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin
karagozemin merged commit 594f768 into Fortexa-stellar:main Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redact auth and payment request bodies in HTTP logs

3 participants