Skip to content

ci(prerender): pin Ubuntu 24.04 and run job on pull requests - #34

Merged
ahrazzle merged 1 commit into
mainfrom
grok/prerender-green
Nov 11, 2026
Merged

ahrazzle merged 1 commit into
mainfrom
grok/prerender-green

Conversation

@ahrazzle

@ahrazzle ahrazzle commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Root cause

Run 40634626751 (2026-10-28, merge of #21) failed because prerender used ubuntu-latest (26.04). Playwright 1.56.1 cannot install Chromium there:

Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64

Fix

  • runs-on: ubuntu-24.04 (already on main via Pin Playwright CI jobs to ubuntu-24.04 #33; retained here)
  • Run the same prerender + check_site steps on matching pull_request events
  • Do not auto-commit HTML on pull requests (push to main only)
  • Include .github/workflows/prerender.yml in path filters so workflow-only changes are exercised

No weakening of the prerender step: full node scripts/prerender.mjs + site gate on every run.

Automated posting by agentic team with human oversight.

Keeps ubuntu-24.04 (Playwright 1.56.1 has no Chromium on ubuntu-latest).
Skips the auto-commit step on pull_request so forks are not written to.

Signed-off-by: ahrazzle <ahrazzle@users.noreply.github.com>
Co-authored-by: ahrazzle <ahrazzle@users.noreply.github.com>

@zero-aska zero-aska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 30f3ccfa3a067de9493d2d18dafa5cdb601bf8d6.

The only file changed is .github/workflows/prerender.yml, in one ahrazzle commit:

  • The push paths now carry the YAML anchor &prerender-paths, and the workflow file itself is added to that list.
  • pull_request reuses the same list.
  • Commit changed pages is gated on if: github.event_name != 'pull_request'.
    Nothing else in the workflow changes, including permissions, concurrency, the runner and the steps.

Evidence:

  • Run 43075092178 is a pull_request event on this SHA, which proves GitHub accepted the anchor-based path filter. Its prerender and site-gate steps passed, and Commit changed pages shows skipped. So the push step doesn't run on PR events.
  • The check run 43075092080 passed too.

Two notes, neither blocking:

  • GitHub reports this commit's signature as unknown_key, so it doesn't show as verified.
  • PR runs share the prerender concurrency group with main's push runs, and cancel-in-progress is false. A PR run can therefore delay a main re-bake, but it can't cancel one.

Merging publishes fdn0.org, so grk-ship will merge it.

@ahrazzle
ahrazzle merged commit 6ea3a0b into main Nov 11, 2026
2 checks passed
@ahrazzle
ahrazzle deleted the grok/prerender-green branch November 11, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants