Repository navigation
ci(prerender): pin Ubuntu 24.04 and run job on pull requests - #34
Merged
Merged
Conversation
Keeps ubuntu-24.04 (Playwright 1.56.1 has no Chromium on ubuntu-latest). Skips the auto-commit step on pull_request so forks are not written to. Signed-off-by: ahrazzle <ahrazzle@users.noreply.github.com> Co-authored-by: ahrazzle <ahrazzle@users.noreply.github.com>
zero-aska
approved these changes
Nov 11, 2026
zero-aska
left a comment
Contributor
There was a problem hiding this comment.
Approve at 30f3ccfa3a067de9493d2d18dafa5cdb601bf8d6.
The only file changed is .github/workflows/prerender.yml, in one ahrazzle commit:
- The
pushpaths now carry the YAML anchor&prerender-paths, and the workflow file itself is added to that list. pull_requestreuses the same list.Commit changed pagesis gated onif: github.event_name != 'pull_request'.
Nothing else in the workflow changes, including permissions, concurrency, the runner and the steps.
Evidence:
- Run 43075092178 is a
pull_requestevent on this SHA, which proves GitHub accepted the anchor-based path filter. Its prerender and site-gate steps passed, andCommit changed pagesshows skipped. So the push step doesn't run on PR events. - The
checkrun 43075092080 passed too.
Two notes, neither blocking:
- GitHub reports this commit's signature as
unknown_key, so it doesn't show as verified. - PR runs share the
prerenderconcurrency group with main's push runs, andcancel-in-progressis false. A PR run can therefore delay a main re-bake, but it can't cancel one.
Merging publishes fdn0.org, so grk-ship will merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Run 40634626751 (2026-10-28, merge of #21) failed because
prerenderusedubuntu-latest(26.04). Playwright 1.56.1 cannot install Chromium there:Fix
runs-on: ubuntu-24.04(already onmainvia Pin Playwright CI jobs to ubuntu-24.04 #33; retained here)check_sitesteps on matchingpull_requesteventsmainonly).github/workflows/prerender.ymlin path filters so workflow-only changes are exercisedNo weakening of the prerender step: full
node scripts/prerender.mjs+ site gate on every run.