Skip to content

Updates and improvements to pre-commit config#662

Open
greenc-FNAL wants to merge 3 commits into
mainfrom
maintenance/pre-commit-config-updates
Open

Updates and improvements to pre-commit config#662
greenc-FNAL wants to merge 3 commits into
mainfrom
maintenance/pre-commit-config-updates

Conversation

@greenc-FNAL

@greenc-FNAL greenc-FNAL commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
  • Add ruff linter to pre-commit checks
  • Back off to a clang-format compatible with the LLVM/Clang we're using
  • Run prek auto-update excluding clang-format
  • CI / pre-commit
    • Updated .pre-commit-config.yaml to refresh pre-commit hook repositories.
    • Added/updated the ruff linter hooks in the pre-commit setup.
    • Pinned clang-format to a version compatible with the current LLVM/Clang toolchain.
    • Ran prek auto-update while excluding the clang-format repository from that automated update.
    • Also bumped related hook repos, including ruff-pre-commit and prettier.

@greenc-FNAL greenc-FNAL requested a review from knoepfel June 24, 2026 23:25
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 81e1f3ae-ab22-4bdd-aa4f-e9f639089ce1

📥 Commits

Reviewing files that changed from the base of the PR and between cb81c8b and 21eeda4.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • Framework-R-D/action-configure-cmake (auto-detected)
  • Framework-R-D/action-workflow-setup (auto-detected)
  • Framework-R-D/action-complete-pr-comment (auto-detected)
  • Framework-R-D/action-handle-fix-commit (auto-detected)
📜 Recent review details
🧰 Additional context used
🔀 Multi-repo context

Linked repositories findings

Framework-R-D/action-workflow-setup

  • .pre-commit-config.yaml:15-18 pins ruff-pre-commit at v0.15.16.
  • .pre-commit-config.yaml:40-43 pins mirrors-prettier at v3.8.3.
  • AGENTS.md:59-71 explicitly tells contributors to use pre-commit/prek, prettier, and ruff.

Framework-R-D/action-configure-cmake

  • .pre-commit-config.yaml:15-18 pins ruff-pre-commit at v0.15.16.
  • .pre-commit-config.yaml:40-43 pins mirrors-prettier at v3.8.3.
  • AGENTS.md:49-61 contains the same formatting/tooling guidance.

Framework-R-D/action-complete-pr-comment

  • .pre-commit-config.yaml:15-18 pins ruff-pre-commit at v0.15.16.
  • .pre-commit-config.yaml:40-43 pins mirrors-prettier at v3.8.3.
  • AGENTS.md:41-53 contains the same formatting/tooling guidance.

Framework-R-D/action-handle-fix-commit

  • .pre-commit-config.yaml:15-18 pins ruff-pre-commit at v0.15.16.
  • .pre-commit-config.yaml:40-43 pins mirrors-prettier at v3.8.3.
  • AGENTS.md:53-65 contains the same formatting/tooling guidance.

No cross-repo consumers of changed APIs/types were found; the only observed overlap is shared pre-commit/tooling configuration pinned to the older versions above.

🔇 Additional comments (1)
.pre-commit-config.yaml (1)

16-23: LGTM!

Also applies to: 57-57


📝 Walkthrough

Walkthrough

Updates the pinned versions of three pre-commit hook repositories in .pre-commit-config.yaml.

Changes

Pre-commit hook version updates

Layer / File(s) Summary
Repo revisions updated
\.pre-commit-config.yaml
Updates the pinned rev values for ruff-pre-commit, mirrors-clang-format, and mirrors-prettier without changing the hook settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the change, but it is too generic to clearly describe the main update. Use a more specific title like "Update pre-commit hooks and pin clang-format compatibility".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maintenance/pre-commit-config-updates

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant