Allow restricting CURLOPT_PROXY with get_curl_resolve_info()#83
Open
Inverle wants to merge 2 commits into
Open
Allow restricting CURLOPT_PROXY with get_curl_resolve_info()#83Inverle wants to merge 2 commits into
CURLOPT_PROXY with get_curl_resolve_info()#83Inverle wants to merge 2 commits into
Conversation
Inverle
force-pushed
the
restrict-curlopt-proxy-ssrf
branch
2 times, most recently
from
cd6a9ed to
3781610
Compare
Inverle
force-pushed
the
restrict-curlopt-proxy-ssrf
branch
from
3781610 to
acb9077
Compare
Alkarex
reviewed
Jun 28, 2026
| } else { // FreshRSS | ||
| defined('CURLPROXY_HTTPS') or define('CURLPROXY_HTTPS', 2); // Compatibility cURL 7.51 | ||
| $proxy_scheme = null; | ||
| switch ($proxy_type) { |
Inverle
commented
Jul 3, 2026
Comment on lines
+499
to
+515
| if ($for_proxy) { | ||
| $parsed = parse_url($url); | ||
| if ($parsed === false) { | ||
| return false; | ||
| } | ||
| $credentials = ''; | ||
| $user = $parsed['user'] ?? null; | ||
| $pass = $parsed['pass'] ?? null; | ||
| if (is_string($user) && is_string($pass)) { | ||
| $credentials = "$user:$pass@"; | ||
| } | ||
| $proxy = $parsed['host'] ?? ''; | ||
| if (is_int($parsed['port'] ?? null)) { | ||
| $proxy .= ':' . $parsed['port']; | ||
| } | ||
| return $credentials . $proxy; | ||
| } |
Member
Author
There was a problem hiding this comment.
Could it be enough to just return the contents after ://?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #76
FreshRSS/FreshRSS#8950