feat(dos-donts): add assets file and tests

[benfrontify]

add assets file and tests

[ragi96]

The ref is already typed useRef<DosDontsAssetsRef>(null) and DosDontsAssetsRef.openUpload is non-optional, so this cast is redundant and actively harmful, it re-types the ref to a weaker shape where the method is optional. If openUpload is ever renamed/removed on the ref, TypeScript won't flag this call and the menu action silently no-ops at runtime. Call the typed ref directly.

Also for the other not only openUpload

[ragi96]

This 2 are important ones, If you don't get why we need to surpress it here, please reach out to me

[benfrontify]

I’m not 100% sure if I resolved the drilling issue. Let me know how this attempt looks.

[fulopdaniel]

I’m not 100% sure if I resolved the drilling issue. Let me know how this attempt looks.

@benfrontify can you kindly explain to me the drilling issue you are trying to solve and your attempt at solving it?

By drilling issue I suspect it's about avoiding to send down a bunch of props through several components?

[benfrontify]

{...props} i used this and Raffi commented on this that I shouldn't do thrilling or pass them one by one

[fulopdaniel]

If you will use my {...props} suggestion, this can be removed and the component is simplified to:

                <ImageComponent
                    onAssetChooseClick={onOpenAssetChooser}
                    onUploadClick={onUploadClick}
                    isUploadLoading={isUploadLoading}
                    isEditing={editing}
                    border={hasBorder ? `${borderWidth} ${borderStyle} ${toRgbaString(borderColor)}` : ''}
                    isDragging={Boolean(isDragging)}
                    {...props}
                />

[ragi96]

I am personally not a big fan of passing props

[fulopdaniel]

Then what about something like this.

1. Provide the block settings via context
2. Create useDoDontItem() and useDoDontAsset() hooks and mount inside the respective component. These consume the block settings and return the necessary callbacks and values - things that right now we pass as props.