Skip to content

[BUGFIX] Fix FlxInputText cursor, selection and click position when scaled #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbnormalPoof merged 3 commits into from
Oct 22, 2026
Merged

[BUGFIX] Fix FlxInputText cursor, selection and click position when scaled #34

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
138a0b3
Fix FlxInputText cursor, selection, and click position when scaling
Pooki-LTSC Oct 22, 2026
1978551
Use transformWorldToPixels for FlxInputText pointer input and account…
Pooki-LTSC Oct 22, 2026
3134546
Rename pointer overlap variable and fix formatting
Pooki-LTSC Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 85 additions & 17 deletions flixel/text/FlxInputText.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,22 @@ class FlxInputText extends FlxText implements IFlxInputText
*/
var _justGainedFocus:Bool = false;

/**
* Stores the origin that sprites were last positioned with, used for checking
* if they need to be updated.
*/
var _lastOrigin:FlxPoint = FlxPoint.get();
/**
* Stores the offset that sprites were last positioned with, used for checking
* if they need to be updated.
*/
var _lastOffset:FlxPoint = FlxPoint.get();
/**
* Stores the scale that sprites were last positioned with, used for checking
* if they need to be updated.
*/
var _lastScale:FlxPoint = FlxPoint.get(1, 1);

/**
* Internal variable that holds the camera that the text field is being pressed on.
*/
Expand Down Expand Up @@ -466,6 +482,14 @@ class FlxInputText extends FlxText implements IFlxInputText
{
regenGraphic();

if (!_lastScale.equals(scale) || !_lastOrigin.equals(origin) || !_lastOffset.equals(offset))
{
_lastScale.copyFrom(scale);
_lastOrigin.copyFrom(origin);
_lastOffset.copyFrom(offset);
updateSpritePositions();
}

drawSprite(_fieldBorderSprite);
drawSprite(_backgroundSprite);

Expand Down Expand Up @@ -493,6 +517,9 @@ class FlxInputText extends FlxText implements IFlxInputText
_backgroundSprite = FlxDestroyUtil.destroy(_backgroundSprite);
_caret = FlxDestroyUtil.destroy(_caret);
_fieldBorderSprite = FlxDestroyUtil.destroy(_fieldBorderSprite);
_lastOffset = FlxDestroyUtil.put(_lastOffset);
_lastOrigin = FlxDestroyUtil.put(_lastOrigin);
_lastScale = FlxDestroyUtil.put(_lastScale);
_pointerCamera = null;
while (_selectionBoxes.length > 0)
FlxDestroyUtil.destroy(_selectionBoxes.pop());
Expand Down Expand Up @@ -631,7 +658,7 @@ class FlxInputText extends FlxText implements IFlxInputText
{
bounds = bounds.clipTo(clipRect);
}
bounds.offset(x - sprite.x, y - sprite.y);
bounds.offset(-worldToFrameX(sprite.x), -worldToFrameY(sprite.y));

sprite.clipRect = rect.clipTo(bounds);

Expand All @@ -646,11 +673,49 @@ class FlxInputText extends FlxText implements IFlxInputText
if (sprite != null && sprite.visible)
{
sprite.scrollFactor.copyFrom(scrollFactor);
sprite.scale.copyFrom(scale);
sprite.origin.set(0, 0);
sprite._cameras = _cameras;
sprite.draw();
}
}

/**
* Gets the X position in the world of the specified X position in the text field,
* takes `scale`, `origin` and `offset` into account.
*/
inline function frameToWorldX(frameX:Float):Float
{
return x - offset.x + origin.x + (frameX - origin.x) * scale.x;
}

/**
* Gets the Y position in the world of the specified Y position in the text field,
* takes `scale`, `origin` and `offset` into account.
*/
inline function frameToWorldY(frameY:Float):Float
{
return y - offset.y + origin.y + (frameY - origin.y) * scale.y;
}

/**
* Gets the X position in the text field of the specified X position in the world,
* takes `scale`, `origin` and `offset` into account.
*/
inline function worldToFrameX(worldX:Float):Float
{
return (worldX - x + offset.x - origin.x) / scale.x + origin.x;
}

/**
* Gets the Y position in the text field of the specified Y position in the world,
* takes `scale`, `origin` and `offset` into account.
*/
inline function worldToFrameY(worldY:Float):Float
{
return (worldY - y + offset.y - origin.y) / scale.y + origin.y;
}

/**
* Returns the specified text filtered using `forceCase` and `filterMode`.
* @param newText The string to filter.
Expand Down Expand Up @@ -1200,8 +1265,8 @@ class FlxInputText extends FlxText implements IFlxInputText
if (!background)
return;

_fieldBorderSprite.setPosition(x - fieldBorderThickness, y - fieldBorderThickness);
_backgroundSprite.setPosition(x, y);
_fieldBorderSprite.setPosition(frameToWorldX(-fieldBorderThickness), frameToWorldY(-fieldBorderThickness));
_backgroundSprite.setPosition(frameToWorldX(0), frameToWorldY(0));
clipSprite(_fieldBorderSprite, true);
clipSprite(_backgroundSprite);
}
Expand All @@ -1216,25 +1281,25 @@ class FlxInputText extends FlxText implements IFlxInputText

if (text.length == 0)
{
_caret.setPosition(x + getCaretOffsetX(), y + GUTTER);
_caret.setPosition(frameToWorldX(getCaretOffsetX()), frameToWorldY(GUTTER));
}
else
{
var boundaries = getCharBoundaries(_caretIndex - 1);
if (boundaries != null)
{
_caret.setPosition(x + boundaries.right - scrollH, y + boundaries.y - getScrollVOffset());
_caret.setPosition(frameToWorldX(boundaries.right - scrollH), frameToWorldY(boundaries.y - getScrollVOffset()));
}
else
{
boundaries = getCharBoundaries(_caretIndex);
if (boundaries != null)
{
_caret.setPosition(x + boundaries.x - scrollH, y + boundaries.y - getScrollVOffset());
_caret.setPosition(frameToWorldX(boundaries.x - scrollH), frameToWorldY(boundaries.y - getScrollVOffset()));
}
else // end of line
{
_caret.setPosition(x + getCaretOffsetX(), y + GUTTER + getLineY(getLineIndexOfChar(_caretIndex)) - getScrollVOffset());
_caret.setPosition(frameToWorldX(getCaretOffsetX()), frameToWorldY(GUTTER + getLineY(getLineIndexOfChar(_caretIndex)) - getScrollVOffset()));
}
}
}
Expand Down Expand Up @@ -1416,7 +1481,7 @@ class FlxInputText extends FlxText implements IFlxInputText
startBoundaries.height);
boxRect.clipTo(FlxRect.weak(0, 0, width, height)); // clip the selection box inside the text sprite

box.setPosition(x + boxRect.x, y + boxRect.y);
box.setPosition(frameToWorldX(boxRect.x), frameToWorldY(boxRect.y));
box.makeGraphic(Std.int(boxRect.width), Std.int(boxRect.height));
clipSprite(box);
box.visible = true;
Expand Down Expand Up @@ -1572,11 +1637,12 @@ class FlxInputText extends FlxText implements IFlxInputText
function checkPointerOverlap(pointer:FlxPointer):Bool
{
var overlap = false;
var pointerPos = FlxPoint.get();
for (camera in getCameras())
{
pointer.getWorldPosition(camera, pointerPos);
if (overlapsPoint(pointerPos, true, camera))
var relativePos = getRelativePosition(pointer, camera);
var pointerOverlaps = relativePos.x >= 0 && relativePos.x < width && relativePos.y >= 0 && relativePos.y < height;
relativePos.put();
if (pointerOverlaps)
{
if (_pointerCamera == null)
_pointerCamera = camera;
Expand All @@ -1585,7 +1651,6 @@ class FlxInputText extends FlxText implements IFlxInputText
}
}

pointerPos.put();
return overlap;
}

Expand Down Expand Up @@ -1722,13 +1787,16 @@ class FlxInputText extends FlxText implements IFlxInputText
}

/**
* Returns the position of the pointer relative to the text field.
* Returns the position of the pointer relative to the text field, using
* `_pointerCamera` if `camera` is `null`.
*/
function getRelativePosition(pointer:FlxPointer):FlxPoint
function getRelativePosition(pointer:FlxPointer, ?camera:FlxCamera):FlxPoint
{
var pointerPos = pointer.getWorldPosition(_pointerCamera, FlxPoint.get());
getScreenPosition(_point, _pointerCamera);
var result = FlxPoint.get((pointerPos.x - _pointerCamera.scroll.x) - _point.x, (pointerPos.y - _pointerCamera.scroll.y) - _point.y);
if (camera == null)
camera = _pointerCamera;

var pointerPos = pointer.getWorldPosition(camera, FlxPoint.get());
var result = transformWorldToPixels(pointerPos, camera);
pointerPos.put();
return result;
}
Expand Down