Repository navigation
Give each role its own sidebar - #326
Merged
vikrantwiz02 merged 1 commit intoSep 30, 2026
Merged
Conversation
The IAM built one navigation list from the union of somebody's permissions, so a person who is both a student and an office holder saw the student's own screens — My Applications, My Offers — while acting as the office. The menus now arrive keyed by designation and the shell renders the acting role's share, the way accessible modules already worked. The iframe's sandbox is not a boundary and the comment said it was: same-origin plus scripts lets the frame drop its own sandbox, and it needs both. What keeps the frame safe is that nothing else is served from this origin as a page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IAM built one navigation list from the union of somebody's permissions, so a person who is both a student and an office holder saw the student's own screens — My Applications, My Offers, Season Registration — while acting as the office.
The menus now arrive keyed by designation and the shell renders the acting role's share, the way
accessible_modulesalready worked.pluggedNavigationbecomes a map, andcurrentPluggedNavigationfollows the role switcher.Also: the iframe's
sandboxis not a boundary and the comment claimed it was. Same-origin plus scripts lets the frame remove its own sandbox, and it needs both. What actually keeps the frame safe is that nothing else — an upload above all — is served from this origin as a page, which the portal PR enforces.Needs FusionIIIT/Fusion#2000 and FusionIIIT/Fusion_System_Administrator's
navigation_by_role, which supplies the per-role payload.457 tests pass, including two new ones on the role-scoped selector.