Skip to content

Fix CI: register ReceiptX icon and update nav test for the new certificate pages - #328

Merged
vikrantwiz02 merged 1 commit into
FusionIIIT:acad-mainfrom
vikrantwiz02:fix/ci-receiptx-icon-and-nav-test
Oct 2, 2026
Merged

vikrantwiz02 merged 1 commit into
FusionIIIT:acad-mainfrom
vikrantwiz02:fix/ci-receiptx-icon-and-nav-test

Conversation

@vikrantwiz02

Copy link
Copy Markdown
Member

Summary

  • CI failed on acad-main after Add the Demand Letter and Fee Structure Certificate screens #327 merged: icons.js only re-exports a curated allowlist from @phosphor-icons/react, and the Demand Letter page's ReceiptX icon wasn't in it, failing the nav test that checks every page icon resolves
  • The other nav test asserting the exact Certificates submenu contents needed the two new entries (Demand Letter, Fee Structure Certificate) added

Test plan

  • 463/463 tests pass locally (was 461 passing / 2 failing before this fix)
  • eslint clean
  • Production build succeeds

…w certificate pages

The Demand Letter page used the ReceiptX icon, but icons.js only
re-exports a curated allowlist from @phosphor-icons/react, and ReceiptX
wasn't in it -- failing the nav test that checks every page icon resolves.
The other nav test asserting the exact Certificates submenu contents also
needed the two new entries added.
@vikrantwiz02
vikrantwiz02 merged commit 48d8718 into FusionIIIT:acad-main Oct 2, 2026
1 check passed
@vikrantwiz02
vikrantwiz02 deleted the fix/ci-receiptx-icon-and-nav-test branch October 2, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant