Repository navigation
Do not persist REPORTED status when the main-table transfer fails - #1996
Merged
vikrantwiz02 merged 1 commit intoSep 17, 2026
Conversation
update_student_status saved reported_status = REPORTED before attempting the ExtraInfo/Student/User transfer, so a failed transfer (batch not found, or any exception during the transfer) left the status permanently stuck at REPORTED with nothing actually created. That also disabled retries, since the guard that triggers the transfer only fires when old_status != REPORTED. Revert the status back to old_status on every failure path in that block, and report success:false with an honest message when the transfer didn't complete. This covers UG, PG and PhD alike since they share this same function.
vikrantwiz02
deleted the
fix/reported-status-revert-on-transfer-failure
branch
September 17, 2026 19:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan