Repository navigation
Scope already-reported students by their actual batch in get_batch_students - #1997
Merged
vikrantwiz02 merged 1 commit intoSep 17, 2026
Conversation
…discipline get_batch_students built its academic_students list (students already transferred to the main academic tables) by matching year + programme type + discipline only, never the specific batch_id. So a reported student leaked into every sibling batch of the same year/discipline/programme type, e.g. a PhD Design student assigned to the Odd 2019 batch also showed up in the Even 2019 batch of the same discipline. Filtering on batch_id scopes it correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan