Skip to content

fix(ci): pass --format-version 1 to cargo metadata validation steps #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1688mengdie wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Open

fix(ci): pass --format-version 1 to cargo metadata validation steps #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa858d0
fix(ci): pass --format-version 1 to cargo metadata validation steps
Aug 27, 2026
793e97b
test(ci): align github-config contract assertions with --format-versi…
1688mengdie Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ jobs:
# Validate the committed manifests and lockfile before any release
# projection is allowed to rewrite workspace package entries.
- name: Verify committed Cargo metadata
run: cargo metadata --locked --no-deps
run: cargo metadata --locked --no-deps --format-version 1

# rust-cache prunes the workspace target directory before saving it, so
# native libraries stored under target need an independent cache lifecycle.
Expand Down Expand Up @@ -504,7 +504,7 @@ jobs:

- name: Verify committed release metadata
if: needs.build-impact.outputs.frontend_required != 'false'
run: cargo metadata --locked --no-deps
run: cargo metadata --locked --no-deps --format-version 1

- name: Verify Installer i18n projection
if: needs.build-impact.outputs.frontend_required != 'false'
Expand Down Expand Up @@ -597,4 +597,4 @@ jobs:

- name: Verify projected release metadata
if: needs.build-impact.outputs.frontend_required != 'false'
run: cargo metadata --locked --no-deps
run: cargo metadata --locked --no-deps --format-version 1
4 changes: 2 additions & 2 deletions scripts/check-github-config.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ test('keeps Rust CI independent, restore-only on PRs, and target-focused', () =>
const verifyMetadata = rustJob.steps.find(
(step) => step.name === 'Verify committed Cargo metadata',
);
assert.equal(verifyMetadata?.run, 'cargo metadata --locked --no-deps');
assert.equal(verifyMetadata?.run, 'cargo metadata --locked --no-deps --format-version 1');
assert.ok(
rustJob.steps.indexOf(verifyMetadata) < rustJob.steps.indexOf(checkCompilation),
'CI must validate the committed Cargo.lock before the workspace check',
Expand Down Expand Up @@ -407,7 +407,7 @@ test('gates fast checks and PR packaging behind one fail-closed build decision',
`${stepName} must run for code changes and skip documentation-only changes`,
);
}
const releaseMetadata = 'cargo metadata --locked --no-deps';
const releaseMetadata = 'cargo metadata --locked --no-deps --format-version 1';
assert.equal(
frontendJob.steps.find((step) => step.name === 'Verify committed release metadata')?.run,
releaseMetadata,
Expand Down