Repository navigation
Conversation
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration |
Contributor
There was a problem hiding this comment.
Faire avec un @ConfigurationProperties comme dans le reste du projet et enlever les @Value
Comment on lines
+39
to
+45
| String id = uid; | ||
| String title = "MON COMPTE ÉTUDIANT"; | ||
| String message = "Votre mot de passe a été mis à jour"; | ||
| List<Channel> channel = List.of(Channel.WEB); | ||
| String idLink = ""; | ||
| Priority priority = Priority.NORMAL; | ||
| TargetType targetType = TargetType.UID; |
Contributor
There was a problem hiding this comment.
rendre les champs final car on ne les modife pas
Comment on lines
+58
to
+64
| String id = uid; | ||
| String title = "MON COMPTE ÉTUDIANT"; | ||
| String message = "Votre email a été mis à jour, avec cette adresse : " + newEmail; | ||
| List<Channel> channel = List.of(Channel.WEB); | ||
| String idLink = ""; | ||
| Priority priority = Priority.NORMAL; | ||
| TargetType targetType = TargetType.UID; |
Contributor
There was a problem hiding this comment.
pareil les champs final
|
|
||
| notificationClient.sendNotification(title, message, idLink, id, channel, priority, targetType); | ||
|
|
||
| log.debug("Le mail de {} a été modifié", id); |
Contributor
There was a problem hiding this comment.
le log c'est plutot "Notification pour changement de mail de {} envoyée"
|
|
||
| notificationClient.sendNotification(title, message, idLink, id, channel, priority, targetType); | ||
|
|
||
| log.debug("Le mot de passe de {} a été mis à jour", id); |
Contributor
There was a problem hiding this comment.
le log c'est plutot "Notification pour changement de mot de passe de {} envoyée"
| notificationClient.sendNotification(title, message, idLink, id, channel, priority, targetType); | ||
|
|
||
| log.debug("Le mail de {} a été modifié", id); | ||
| }catch (Exception e) { |
Contributor
There was a problem hiding this comment.
espace après l'accolade
| notificationClient.sendNotification(title, message, idLink, id, channel, priority, targetType); | ||
|
|
||
| log.debug("Le mot de passe de {} a été mis à jour", id); | ||
| }catch (Exception e) { |
Contributor
There was a problem hiding this comment.
espace après l'accolade
| @Component | ||
| @Aspect | ||
| @Slf4j | ||
| @Data |
Contributor
There was a problem hiding this comment.
est-ce que le @Data est nécéssaire car on expose pas de getter/setter ? à tester
emt-coder
force-pushed
the
notifications_preferences
branch
from
August 18, 2026 09:47
4a72185 to
4510034
Compare
emt-coder
force-pushed
the
notifications_preferences
branch
from
August 18, 2026 09:48
4510034 to
57acfb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.