Skip to content

AdrianBenson/issue36 - #57

Open
AdrianBenson wants to merge 35 commits into
mainfrom
AdrianBenson/issue36
Open

AdrianBenson wants to merge 35 commits into
mainfrom
AdrianBenson/issue36

Conversation

@AdrianBenson

@AdrianBenson AdrianBenson commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Add funtion to catch situations wehere clipping removes too much/the wrong things.

Closes #36

Adrian Benson added 30 commits September 13, 2026 00:18
…coderefactor:

update include_unknown_fields default to True and clean up code
- Updated import statements to include new utility functions.
- Enhanced readability by breaking long lines and improving variable names.
- Replaced instances of `isinstance` checks with more type-safe alternatives.
- Corrected typos and improved documentation for clarity.
- Ensured consistent naming conventions for variables and parameters.
- Refactored logic in various functions to streamline processing and enhance performance.
- Added type hints for better type checking and code clarity.
- Improved error messages for better debugging experience.
Required because they are explicitly imported.
@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.29%. Comparing base (37aa0c3) to head (6b26aa2).

Files with missing lines Patch % Lines
src/gsolve/gsolve_algorithms.py 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   65.03%   65.29%   +0.25%     
==========================================
  Files          22       22              
  Lines        4156     4192      +36     
  Branches      803      811       +8     
==========================================
+ Hits         2703     2737      +34     
- Misses       1179     1180       +1     
- Partials      274      275       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@craigmillernz
craigmillernz self-requested a review September 30, 2026 00:21
Comment thread src/gsolve/gsolve_algorithms.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catch if percentile clip removes too many repeats

2 participants