Repository navigation
fix: bump go-jose to v4.1.6 in frpc build and clear operator staticcheck - #814
Conversation
The vuln (images) Trivy scan fails on master and every PR: the frpc binary in the tunnel-frp image embeds github.com/go-jose/go-jose/v4 v4.1.4 (CVE-2026-116587, HIGH, fixed in 4.1.6). #811 only bumped the operator; tunnel/frpc/go.mod still pinned 4.1.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The error matches master's run 40869672773 line for line: It came in with 7affd86 (merged in #760). No open PR fixes it yet. The proposed fix matches the pattern - return ctrl.Result{Requeue: true}, nil
+ return ctrl.Result{RequeueAfter: time.Nanosecond}, nilI haven't applied it because it's a production code change outside this PR's scope, so it waits on the maintainer's call. Generated by Claude Code |
staticcheck SA1019 fails lint (operator) on master since #760: use RequeueAfter: time.Nanosecond, matching restore_controller.go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
CI Report - 906f4d7run 40973833978 - attempt 2 0 failed - 24 passed - 9 skipped - unknown elapsed Test selection: partial - per-suite table Coverageno coverage/* commit statuses found on 906f4d7 Changed
Slowest jobsno job duration data available e2e buckets run
|
Summary
Master currently fails two checks, and this PR fixes both.
1.
vuln (images): go-jose v4.1.4 in frpcThe only finding comes from the
tunnel-frpimage:Source: master run 40869672773 (b07e4d4). PR #768 fails with the same lines. The other 11 images scan clean.
tunnel/Dockerfile.frpbuildsfrpcfromtunnel/frpc/go.mod, and that file still pinned go-jose v4.1.4. #811 bumped only the operator, andapiandoperatorwere already on v4.1.6.tunnel/frpc/go.mod:github.com/go-jose/go-jose/v4goes from v4.1.4 to v4.1.6.tunnel/frpc/go.sum: adds the v4.1.6 hashes and drops the v4.1.4 ones.go mod tidycan't run on this module because it has no.gofiles, so tidy would empty the require block.2.
lint (operator): staticcheck SA1019This line was red on master from the moment #760 merged (7affd86). The fix replaces
ctrl.Result{Requeue: true}withctrl.Result{RequeueAfter: time.Nanosecond}, the same form the matchingprogressedbranch inrestore_controller.go:199-200already uses.Verification
GOFLAGS=-mod=readonly go build -tags frpc,noweb github.com/fatedier/frp/cmd/frpc).go version -mshowsdep github.com/go-jose/go-jose/v4 v4.1.6.go build ./...andgo vet ./internal/controller/pass inoperator/.🤖 Generated with Claude Code