Repository navigation
fix(deps): force minimatch ^11.0.1 globally via overrides - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the glob/minimatch override fix: alert #34 (minimatch, GHSA-g3hv-75wg-m249) stayed open after that merge because Dependabot then counted the remaining old copies — minimatch 5.1.9 inside filelist (electron-builder chain) and inside archiver (exceljs chain), with further old copies (3.1.5, 9.0.9) nested in the Electron packaging tools behind them.
This change replaces the scoped minimatch overrides with a single global override,
"minimatch": "^11.0.1", so every consumer in the tree resolves to the patched major. The scoped overrides for @eslint/config-array, @typescript-eslint/typescript-estree, app-builder-lib, eslint, and test-exclude, and the nested readdir-glob pin, are removed as redundant — the observable tree is now exactly one minimatch copy: 11.0.3.Scope note: this deliberately forces the ESM-only minimatch 11 into the CommonJS Electron packaging tools (@electron/asar, @electron/universal, filelist, dir-compare). The maintainer has confirmed the Electron app is not currently in use and asked for the fix from a vulnerability-closure point of view. The packaging path is not covered by the unit suite; module-load smokes for those tools pass, and a full packaging run should be re-validated before the next Electron release build.
Verification in a clean scratch copy of main (
28aba2f):npm ciinstalls the lockfile cleanly (in sync)tscclean,eslintclean,prettier --checkclean