Repository navigation
fix(deps): restore readdir-glob@3.0.0 lockfile entry for npm 11 ci - #163
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the red CI on main after the minimatch override change. Lockfile-only; package.json is untouched.
Root cause: the lockfile shipped with the global minimatch override contains no
readdir-glob@3.0.0entry, even though the exceljs override pinsreaddir-glob: ^3.0.0for that subtree.npm ciunder npm 10 (Node 22 line, and local verification) accepts the lockfile, but npm 11 (Node 24 and 26 lines) runs a stricter package.json/lockfile sync check and fails the install step with "Missing: readdir-glob@3.0.0 from lock file" — every 24.x/26.x test job on the PR and on main died at install, before any test ran.Fix: one install pass with npm 11 against the current main, which restores
node_modules/readdir-globat 3.0.0 in the lockfile (+15/−9 lines, no version changes anywhere — minimatch stays a single 11.0.3, glob stays 14.0.3).Verification in scratch on top of main (
765efa0):npm ciexit 0 under BOTH npm 11.7 (via npx) and npm 10.9.4tscclean,eslintclean,prettier --checkcleanGoing forward, lockfile changes are verified with both npm generations before shipping.