Skip to content

test: StoryF4 engine-config spec tests a stale private copy of the endpoint #880

Description

@genwave-radio

🧪 Problem

tests/GenWave.Host.Tests/Specs/StoryF4_EngineConfigEndpoint.cs tests a private copy of the endpoint's logic (InvokeEndpointHandler, line 170), not the real /internal/engine-config endpoint.

The copy has drifted. ResponseIsExactlyTwoLines (line 76) still asserts 2 lines, but the real endpoint now returns 4 keys: GW_XFADE_MIN, GW_XFADE_MAX, GW_SAFE_GAP_SECONDS and GW_APP_VERSION (F211, v5.14.0). The spec stays green while testing nothing real.

✅ Fix

Delete the copy. Drive the real endpoint through WebApplicationFactory, the way Story485's EngineConfigArc does, or drop the facts that the WAF-based specs already cover.

Found in review of T594 (d5b10c5); the drift predates that task.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions