Repository navigation
Adopt inspect-evals-lint 0.4.2 (template v1.2.0) and retire the .noautolint suppressions - #17
Open
MattFisher wants to merge 2 commits into
Open
MattFisher wants to merge 2 commits into
MattFisher wants to merge 2 commits into
Conversation
…plate v1.2.0) The lint-related managed files are merged from the template (checks.yml and run_checks.sh run `uv run inspect-evals-lint --all`, AUTOMATED_CHECKS.md documents the rules and the new suppression syntax); tools/run_autolint is removed; pyproject.toml gains the dev dependency and the [tool.inspect-evals-lint] table. The lab_bench_2 extra declares pillow and pydantic, which the evaluation imports directly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Neither entry needs carrying over. The linter now treats the repository's own src/utils as first-party, and tests/__init__.py makes the test package tests.lab_bench_2, which no longer shadows src/lab_bench_2, so the test directories can have __init__.py files. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains
Description
This repository was created from inspect-evals-template v1.1.0, whose structural checks ran from a vendored
tools/run_autolint. Template v1.2.0 replaced that with the inspect-evals-lint package, which is also what the register's daily lint service runs against this repository at its registered commit. The package removed thenoautolintsuppression syntax, so the service currently reports this repository's old suppression as a dead marker (src/lab_bench_2/.noautolint). This PR brings the repository onto the package and migrates the suppression.What changes
pyproject.toml(yours, so the template sync does not touch it):inspect-evals-lint==0.4.2in thedevgroup and a[tool.inspect-evals-lint]table with thetemplatepreset..github/workflows/checks.ymlandtools/run_checks.shrunuv run inspect-evals-lint --all(CI annotates pull requests at the offending lines),AUTOMATED_CHECKS.mddocuments the rules and the new# inspect-evals-lint: ignore[<rule>]comment syntax, plusAGENTS.md,CONTRIBUTING.md,MANAGED_FILES.md, the two Claude skills and.template-version(v1.2.0).tools/run_autolint/is removed. The autolint check stays advisory (ENFORCE_AUTOLINT=false), as before.src/utils/huggingface.py: the template's own line-level suppression for the deferreddatasetsimport, which the helper package needs until an evaluation here declaresdatasets.src/lab_bench_2/.noautolintis deleted, and neither of its two entries needs replacing:external_dependencieswas suppressed because the linter reported the repository's ownsrc/utilshelper as an undeclared third-party package. inspect-evals-lint 0.4.2 treats every package undersrc/as first-party.tests_initwas suppressed because atests/lab_bench_2/__init__.pymade pytest see two modules namedlab_bench_2. Addingtests/__init__.pyas well fixes that (the test package becomestests.lab_bench_2);tests/lab_bench_2/__init__.pyandtests/lab_bench_2/solvers/__init__.pyare added too. All 242 tests still collect and mypy is clean.[project.optional-dependencies].lab_bench_2gainspillowandpydantic, whichattachment_builder.pyandscorers.pyimport directly but which were only available transitively. (from evals.utils import MEDIA_TYPESresolves to the declaredlabbench2distribution once it is installed, so it needs nothing.)Result (
uv run inspect-evals-lint --allwith 0.4.2):utilspasses.lab_bench_2has one remaining failure, left for a separate decision:Score.unscored()atscorers.py:102passes noreason=, which needsinspect_ai>=0.3.261(the repository pins>=0.3.234). Three warnings do not fail the run:get_model()outside a@scorerincall_grader_with_retry, and twodockerfile_lockingfindings insolvers/Dockerfile(undigestedFROM aisiuk/inspect-tool-support, an unlockedpip installlist).Verification:
uv run pytest --collect-only,uv run mypy src testsanduv run ruff check/ruff format --checkpass locally on this branch;uv lockis refreshed.Checklist
Are you adding a new eval?
Does this change affect existing eval(s)?
Does this change affect how future contributors write or submit evaluations (e.g. new required fields, changed tooling, updated conventions)?
AUTOMATED_CHECKS.md,CONTRIBUTING.mdandAGENTS.mdare updated from the template.Posted by Claude Code on Matt Fisher's behalf. Matt maintains the inspect_evals register that lists this evaluation.
🤖 Generated with Claude Code