Repository navigation
docs: clarify adapter session identity ownership - #1421
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe integrations guide now documents session identity mapping and registration checks for Claude Code, Codex, and OpenCode. It also identifies which session rules Go owns. ChangesAdapter session identity
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This documentation-only change accurately describes the adapters’ session identity and registration behavior, including OpenCode’s acknowledgment limitation. It is ready to merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit resume |
✅ Action performedReviews resumed and review finished. |
0359b8d
🔗 Linked Issue
Closes #1419
Related to #737, which remains the global documentation tracker.
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoring (no behavior change)type:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking change📝 Summary
📂 Changes
docs/codebase/integrations.md🧪 Test Plan
go test ./...(not run; CI owns the broad suite)go test -tags e2e ./internal/server/...(not run; documentation-only)make lint(not run; documentation-only)Focused verification passed:
node --test plugin/opencode/engram.test.mjs— 81 passed, 0 failed.go test ./internal/mcp -run 'Test(OmittedSessionIDRejectsAmbiguousActiveSessions|HandleSaveResolvesActiveSessionFromStore)' -count=1 -timeout=90s— passed.git diff --check— passed.Unverified locally:
go test ./internal/store ./internal/server ./internal/mcp ./plugintimed out twice (120s and 600s) without output. It was not retried again; a passing focused test is not a passing broad suite. CI owns the required full unit suite. No runtime behavior changed.🤖 Automated Checks
CI is pending. All required checks must pass before merge.
✅ Contributor Checklist
Closes #1419)type:*label to this PRgo test ./...(not run; CI owns the broad suite)go test -tags e2e ./internal/server/...(not run; documentation-only)make lint(not run; documentation-only)Co-Authored-Bytrailers in commitsdocs/codebase/integrations.mdonly)💬 Notes for Reviewers
Review the adapter mapping table and registration acknowledgment column first. This describes current behavior, including OpenCode's lack of matching-ID validation on HTTP-success registration replies; it does not implement a fix. End-session semantics from open PR #1250 and archive lifecycle are intentionally out of scope.
Summary by CodeRabbit