Repository navigation
feat(store): preview one exact prompt source without authority - #1545
Merged
dnlrsls merged 1 commit intoSep 29, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dnlrsls
merged commit Sep 29, 2026
f800a69
into
Gentleman-Programming:feat/prompt-inbox-foundation-tracker
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #1458
Child 1 of the explicit reauthorization work for open tracker #1464. Base:
feat/prompt-inbox-foundation-trackerat1d70f3b3, notmain.🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenancetype:breaking-change— Breaking change📝 Summary
📂 Changes
internal/store/store.goPreviewPromptSourcereads live and tombstone rows together with a two-row ambiguity bound.internal/store/prompt_local_origin_test.go134 authored additions. Documentation N/A: this internal read has no CLI or remote behavior until subsequent children.
🧪 Test Plan
go test ./internal/store -run 'TestPreviewPromptSource' -count=1— PASS (independent verifier).go test ./internal/store -count=1— PASS (independent verifier).go vet ./internal/store, gofmt listing andgit diff --check— PASS; only LF→CRLF advisory warnings. Native reviewreview-1dc16dbe3c394613approved and acknowledged; one nonblocking test-readability suggestion.🤖 Automated Checks
CI results pending. Required checks must pass before normal merge.
✅ Contributor Checklist
type:featurelabel.💬 Notes for Reviewers
This does not reauthorize any source. A future CLI will require an explicitly asserted owner project and human confirmation; the server must authenticate the actor, check current grants for both owner and prompt projects, and record a distinct per-source attestation. A returned prompt
Projectis data, not proof of session ownership. Do not queue #1464 or enable remote deletes until the remaining reauthorization children, cloud delete gate and integrated validation are complete.